Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate: Change translate for admin.config.enable_captcha #11657

Merged
merged 4 commits into from
May 29, 2020

Conversation

a1012112796
Copy link
Member

add 'register' to make it more accurate

sadly, it has been misunderstood by Chinese translators, It was translated as "enable login CAPTCHA".😂
image

add 'register' to make it more accurate

Signed-off-by: a1012112796 <[email protected]>
@a1012112796
Copy link
Member Author

image

image

What happend?🤔 @lunny

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 28, 2020
@CirnoT
Copy link
Contributor

CirnoT commented May 28, 2020

You can always propose change on Crowdin if some translation got it wrong.

@a1012112796
Copy link
Member Author

You can always propose change on Crowdin if some translation got it wrong.

I'm sorry, I haven't check Crowdin before, but after check it , I found an amazing thing , that the translation in cowdin is “启用验证码”,but the translation pushed by crowdin bot is "启用登录验证码" which is different with cowdin , I wander ....
This pr is am to change english version form "" Enable CAPTCHA" to "Enable register CAPTCHA" to make it more exact. The english version can't change in crowdin. Thanks.

options/locale/locale_en-US.ini Outdated Show resolved Hide resolved
Co-authored-by: Cirno the Strongest <[email protected]>
Copy link
Contributor

@CirnoT CirnoT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 29, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 29, 2020
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label May 29, 2020
@lafriks lafriks merged commit ab73b56 into go-gitea:master May 29, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
…#11657)

* translate: Change translate for admin.config.enable_captcha

add 'register' to make it more accurate

Signed-off-by: a1012112796 <[email protected]>

* Update options/locale/locale_en-US.ini

Co-authored-by: Cirno the Strongest <[email protected]>

Co-authored-by: Cirno the Strongest <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants