Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not show avatar for "{{user}} added X commits" #11591

Merged
merged 2 commits into from
May 24, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented May 23, 2020

Looks weird when there's only one commit + GitHub doesn't show it either.

chrome_2020-05-23_23-55-42

Before:
chrome_2020-05-23_23-57-31

After:
chrome_2020-05-23_23-56-15

@CirnoT
Copy link
Contributor Author

CirnoT commented May 23, 2020

Maybe better representation of why it looks weird:

chrome_2020-05-23_23-58-54

vs

chrome_2020-05-23_23-59-07

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 23, 2020
@jolheiser jolheiser added the topic/ui Change the appearance of the Gitea UI label May 24, 2020
@jolheiser jolheiser added this to the 1.13.0 milestone May 24, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 24, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 24, 2020
@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit 39b792f into go-gitea:master May 24, 2020
@CirnoT CirnoT deleted the commits-av branch May 24, 2020 20:37
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants