Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix webpack chunk loading with STATIC_URL_PREFIX (#11526) #11544

Merged
merged 2 commits into from
May 28, 2020
Merged

Fix webpack chunk loading with STATIC_URL_PREFIX (#11526) #11544

merged 2 commits into from
May 28, 2020

Conversation

silverwind
Copy link
Member

Backport of #11526 to 1.11.

@silverwind @zeripath @lafriks
Fix webpack chunk loading with STATIC_URL_PREFIX (go-gitea#11526)
85f30ce 
Previously, we had only set __webpack_public_path__ to a path which
caused webpack chunks to be loaded from the current origin which is
incorrect when STATIC_URL_PREFIX points to another origin.

This should fix the issue curretnly seen on gitea.com.

Co-authored-by: zeripath <[email protected]>
Co-authored-by: Lauris BH <[email protected]>
@zeripath
Copy link
Contributor

zeripath commented May 22, 2020 •
edited
Loading

I don't think 1.11 has static URL prefix

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 22, 2020
@silverwind
Copy link
Member Author

Actually, it has.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 22, 2020
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label May 22, 2020
@zeripath zeripath added this to the 1.11.6 milestone May 22, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 28, 2020
@techknowlogick
Copy link
Member

ping LG-TM

@techknowlogick techknowlogick merged commit c0c3a53 into go-gitea:release/v1.11 May 28, 2020
@silverwind silverwind deleted the backport-11526-111 branch May 29, 2020 04:07
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.11.6
Development

Successfully merging this pull request may close these issues.
5 participants
@silverwind @zeripath @techknowlogick @mrsdizzie @GiteaBot