Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip compliance and testing steps where possible on branches and tags #11513

Closed
wants to merge 3 commits into from

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented May 19, 2020

As title. Run only unit-test and mysql integration tests on master branch for coverage report

Hopefully I did not break anything, not something I could test 🙄

@lafriks lafriks added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. labels May 19, 2020
@lafriks lafriks added this to the 1.13.0 milestone May 19, 2020
.drone.yml Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 19, 2020
Copy link
Contributor

@CirnoT CirnoT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing-amd64 depends on compliance; I don't remember how Drone will behave if pipeline depends on skipped pipeline.

@lafriks
Copy link
Member Author

lafriks commented May 19, 2020

I thought it executes even if dependency is not run, otherwise notifications pipline (last one in this file) would not be run ever as it depends on all other pipelines

@lafriks
Copy link
Member Author

lafriks commented May 20, 2020

@CirnoT done

@lafriks
Copy link
Member Author

lafriks commented May 20, 2020

I split master push coverage to other pipeline coverage

@CirnoT
Copy link
Contributor

CirnoT commented May 20, 2020

We already use coverage as name for step that uploads to codecov, re-using it for pipeline step is valid but confusing. Perhaps testing-master?

.drone.yml Outdated Show resolved Hide resolved
@lafriks
Copy link
Member Author

lafriks commented May 20, 2020

@CirnoT done

@CirnoT
Copy link
Contributor

CirnoT commented May 20, 2020

Looks good from my end, however someone should run it locally to double verify that dependency graph acts as desired.

@stale
Copy link

stale bot commented Jul 19, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Jul 19, 2020
@lafriks
Copy link
Member Author

lafriks commented Jul 19, 2020

Bad bot

@stale stale bot removed the issue/stale label Jul 19, 2020
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Sep 10, 2020
@lunny lunny modified the milestones: 1.13.0, 1.14.0 Sep 10, 2020
@lunny
Copy link
Member

lunny commented Feb 22, 2021

Please resolve the conflicts

@6543 6543 modified the milestones: 1.14.0, 1.15.0 Feb 25, 2021
@zeripath
Copy link
Contributor

as per discussion on discord - I'm closing this. @lafriks please re-open and fix conflicts if you think we should merge this.

@zeripath zeripath closed this Jun 23, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
@techknowlogick techknowlogick removed this from the 1.15.0 milestone Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants