Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log slow tests #11487

Merged
merged 4 commits into from
Jun 2, 2020
Merged

log slow tests #11487

merged 4 commits into from
Jun 2, 2020

Conversation

zeripath
Copy link
Contributor

Add some logging to the integration tests when there is a slow test or slow flush.

Signed-off-by: Andrew Thornton [email protected]

@zeripath
log slow tests
52c9d85 
Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added this to the 1.13.0 milestone May 18, 2020
@zeripath
placate lint
efde3ad 
Signed-off-by: Andrew Thornton <[email protected]>
6543
6543 reviewed May 18, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this may fix the lint - but didn't tested it jet

integrations/testlogger.go Outdated Show resolved Hide resolved
integrations/testlogger.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 18, 2020
6543
6543 approved these changes May 19, 2020
View reviewed changes
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new log stile

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 19, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 2, 2020
@techknowlogick
Copy link
Member

Ping lg-tm

@techknowlogick techknowlogick merged commit 14ca111 into go-gitea:master Jun 2, 2020
@zeripath zeripath deleted the log-slow-tests branch June 2, 2020 06:52
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@zeripath @6543 @techknowlogick
log slow tests (go-gitea#11487)
cddc418 
* log slow tests

Signed-off-by: Andrew Thornton <[email protected]>

* placate lint

Signed-off-by: Andrew Thornton <[email protected]>

* More lint placation

Co-authored-by: 6543 <[email protected]>

Co-authored-by: 6543 <[email protected]>
Co-authored-by: techknowlogick <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@6543 6543 6543 approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/testing
Projects
None yet
Milestone
1.13.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zeripath @techknowlogick @6543 @GiteaBot