Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Avoid '0 new commits' messages to be send to webhook" #11397

Merged
merged 1 commit into from
May 13, 2020

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented May 13, 2020

Reverts #11082

As per comments by @CirnoT this breaks drone and likely other things as it directly moves us away from GitHub behaviour.

The 0 commits information should be handled elsewhere.

Reopens #10498

@zeripath zeripath added this to the 1.12.0 milestone May 13, 2020
@CirnoT
Copy link
Contributor

CirnoT commented May 13, 2020

Relevant harness/harness#2966 (comment)

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 13, 2020
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 13, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 13, 2020
@lafriks lafriks merged commit 8d212f7 into master May 13, 2020
@lafriks lafriks deleted the revert-11082-avoid_0_new_commits_notify branch May 13, 2020 07:51
@zeripath
Copy link
Contributor Author

@CirnoT - I see you've had 10 PRs merged - would you like to apply to be a maintainer?

@kolaente
Copy link
Member

I can confirm this fixes it for drone on my instance - thanks!

@zeripath zeripath added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label May 17, 2020
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants