Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pagination headers on endpoints that support total count from database #11145

Merged
merged 10 commits into from
Jun 21, 2020

Conversation

CirnoT
Copy link
Contributor

@CirnoT CirnoT commented Apr 19, 2020

Adds pagination headers to endpoints that currently return total count of elements from database

Ref #11114

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 4, 2020
@CirnoT CirnoT changed the title [WIP] API Generalize Header for get XY list endpoints Add pagination headers on endpoints that support total count from database Jun 20, 2020
@CirnoT CirnoT marked this pull request as ready for review June 20, 2020 14:05
@CirnoT
Copy link
Contributor Author

CirnoT commented Jun 20, 2020

Marking this as ready to PR. It's only partial but it includes support for various important endpoints that Drone and other tools can use.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 20, 2020
@zeripath zeripath added the modifies/api This PR adds API routes or modifies them label Jun 20, 2020
@zeripath zeripath added this to the 1.13.0 milestone Jun 20, 2020
Copy link
Member

@6543 6543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 20, 2020
@lunny lunny merged commit 81324cf into go-gitea:master Jun 21, 2020
@CirnoT CirnoT deleted the patch-6 branch June 21, 2020 09:35
ydelafollye pushed a commit to ydelafollye/gitea that referenced this pull request Jul 31, 2020
…abase (go-gitea#11145)

* begin work

* import fmt

* more work

* empty commit

Co-authored-by: Lauris BH <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants