Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix milestones too many SQL variables bug (#10880) #10904

Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Mar 31, 2020

backport from #10880

  • Fix milestones too many SQL variables bug
  • Fix test
  • Don't display repositories with no milestone and fix tests
  • Remove unused code and add some comments

* Fix milestones too many SQL variables bug

* Fix test

* Don't display repositories with no milestone and fix tests

* Remove unused code and add some comments
@lunny lunny added the type/bug label Mar 31, 2020
@lunny lunny added this to the 1.11.4 milestone Mar 31, 2020
@GiteaBot GiteaBot added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Mar 31, 2020
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 31, 2020
@jolheiser jolheiser merged commit 139fc7c into go-gitea:release/v1.11 Mar 31, 2020
@guillep2k guillep2k mentioned this pull request Apr 1, 2020
7 tasks
@lunny lunny deleted the lunny/fix_milestone_too_many_in branch April 1, 2020 03:34
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants