Convert plumbing.ErrObjectNotFound to git.ErrNotExist in getCommit #10862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunny
reviewed
Mar 28, 2020
GiteaBot
added
the
lgtm/need 2
lafriks
reviewed
Mar 28, 2020
lafriks
approved these changes
Mar 28, 2020
GiteaBot
added
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #10862 +/- ##
==========================================
- Coverage 43.40% 43.39% -0.01%
==========================================
Files 593 593
Lines 83271 83276 +5
==========================================
+ Hits 36140 36141 +1
Misses 42640 42640
- Partials 4491 4495 +4
Continue to review full report at Codecov.
|
guillep2k
approved these changes
Mar 28, 2020
| if err == nil { | ||
| gogitCommit, err = repo.gogitRepo.CommitObject(tagObject.Target) | ||
| } | ||
| // if we get a plumbing.ErrObjectNotFound here then the repository is broken and it should be 500 |
There was a problem hiding this comment.
Although I'd prefer a "your repository is broken" error. 😉
GiteaBot
added
lgtm/done
|
Please send backport |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Mar 28, 2020
…o-gitea#10862) Co-authored-by: Lauris BH <[email protected]> Co-authored-by: guillep2k <[email protected]> Co-authored-by: Antoine GIRARD <[email protected]>
zeripath
added a commit
that referenced
this pull request
Mar 29, 2020
…10862) (#10868) Backport #10862 Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: Lauris BH <[email protected]> Co-authored-by: guillep2k <[email protected]> Co-authored-by: Antoine GIRARD <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to a number of other bugs we need to handle plumbing.ErrObjectNotFound and convert to git.ErrNotExist appropriately.
Fix #10852