-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add request review from specific reviewers feature in pull request #10756
Merged
Commits on Apr 2, 2020
-
add request review feature in pull request
add a way to notify specific reviewers to review like github , by add or delet a special type review . The acton is is similar to Assign , so many code reuse the function and items of Assignee, but the meaning and result is different. The Permission style is is similar to github, that only writer can add a review request from Reviewers, but the poster can recall and remove a review request after a reviwer has revied even if he don't have Write Premission. only manager , the poster and reviewer of a request review can remove it. The reviewers can be requested to review contain all readers for private repo , for public, contain all writers and watchers. The offical Review Request will block merge if Reject can block it. an other change: add ui otify for Assignees. Co-authored-by: guillep2k <[email protected]> Co-authored-by: Lauris BH <[email protected]> Signed-off-by: a1012112796 <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for ff59626 - Browse repository at this point
Copy the full SHA ff59626View commit details -
Configuration menu - View commit details
-
Copy full SHA for 29a6d24 - Browse repository at this point
Copy the full SHA 29a6d24View commit details
Commits on Apr 3, 2020
-
Configuration menu - View commit details
-
Copy full SHA for eec5b83 - Browse repository at this point
Copy the full SHA eec5b83View commit details
Commits on Apr 4, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 15ead8a - Browse repository at this point
Copy the full SHA 15ead8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3397d56 - Browse repository at this point
Copy the full SHA 3397d56View commit details
Commits on Apr 5, 2020
-
do some changes follow go-gitea#10238 to add review requests num on l…
…ists also change icon for review requests to eye
Configuration menu - View commit details
-
Copy full SHA for 0813a58 - Browse repository at this point
Copy the full SHA 0813a58View commit details -
Configuration menu - View commit details
-
Copy full SHA for d619417 - Browse repository at this point
Copy the full SHA d619417View commit details
Commits on Apr 6, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 543425f - Browse repository at this point
Copy the full SHA 543425fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 57470f8 - Browse repository at this point
Copy the full SHA 57470f8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08b81ec - Browse repository at this point
Copy the full SHA 08b81ecView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.