Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

First comment in code review gets lost #8942

Closed
guillep2k opened this issue Nov 13, 2019 · 1 comment · Fixed by #8943
Closed

First comment in code review gets lost #8942

guillep2k opened this issue Nov 13, 2019 · 1 comment · Fixed by #8943

Comments

@guillep2k
Copy link
Member

  • Gitea version (or commit ref): 1.11.0+dev-234-g62f59ebcc

Description

When I start a review for a PR (Start review button), the comment that I added gets lost. I continue to be in "review" mode, and the comments I add after the first are accepted.
@guillep2k
Copy link
Member Author

The problem comes from the fact that services/pull:CreateReview() calls notification.NotifyPullRequestReview() when the comment is still not created. 🙁

@guillep2k guillep2k mentioned this issue Nov 13, 2019
Merged
lunny pushed a commit that referenced this issue Nov 15, 2019
@blueworrybear @lunny
Expand/Collapse Files and Blob Excerpt while Reviewing/Comparing code (…
149a9df 
…#8924)

* update #8659 fold/unfold code diffs

* add fold button style

* update #8659 implement expand up/down codes (blob excerpt)

* fix golint errors

* fix expand direction

* remove debug message

* update css style for blob exceprt

* fix typo in comment

* update style sheet with less

* update expect diff (add SectionInfo)

* update #8942 accept suggested change (fix typo)

* close reader and check file type before get tail section

* adjust button position and check file type before insert fold button

* move index js to web_src

* merge index.js with master

* generate index.js

* update js coding style
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't send notification on pending reviews guillep2k/gitea
1 participant
@guillep2k