Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API User search now fails if not using token #6881

Closed
richmahn opened this issue May 8, 2019 · 0 comments · Fixed by #6882
Closed

API User search now fails if not using token #6881

richmahn opened this issue May 8, 2019 · 0 comments · Fixed by #6882
Labels
modifies/api This PR adds API routes or modifies them type/bug
Milestone
1.8.2

Comments

@richmahn
Copy link
Contributor

richmahn commented May 8, 2019 •
edited
Loading

User search in the API now fails due to null pointer since the code checks ctx.User.IsAdmin. If not logged in (no token or authorization) this fails.

Version: v1.8.0
@techknowlogick techknowlogick added modifies/api This PR adds API routes or modifies them type/bug labels May 8, 2019
@techknowlogick techknowlogick added this to the 1.8.2 milestone May 8, 2019
richmahn added a commit to richmahn/gitea that referenced this issue May 8, 2019
@richmahn
Fixes go-gitea#6881 - API users search fix
3b8945f
@richmahn richmahn mentioned this issue May 8, 2019
Merged
lafriks pushed a commit that referenced this issue May 8, 2019
@richmahn @lafriks
Fixes #6881 - API users search fix (#6882)
6db3dc7
richmahn added a commit to richmahn/gitea that referenced this issue May 9, 2019
@richmahn
Fixes go-gitea#6881 - API users search fix (go-gitea#6882)
cf3c1ea
@richmahn richmahn mentioned this issue May 9, 2019
Merged
lunny pushed a commit that referenced this issue May 9, 2019
@richmahn @lunny
Fixes #6881 - API users search fix (#6882) (#6885)
c8fc7fc
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
modifies/api This PR adds API routes or modifies them type/bug
Projects
None yet
Milestone
1.8.2
Development

Successfully merging a pull request may close this issue.

Fixes #6881 - API users search fix richmahn/gitea
2 participants
@techknowlogick @richmahn