-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.7.0 lfs regression #5657
Comments
We get the user's access token as user and "x-oauth-basic" as password. The "main" repository module already accepts this type of token so lfs should too. drone.io uses this so lfs access to private repos is now granted and avoids the regression from go-gitea#5657 for my drone scenario (since drone with the default git plugin requests are already authenticated).
Have reproduced this: when you clone via |
@lunny it should not ask password for public repo |
A public repo and REQUIRE_SIGNIN_VIEW is not set true, the password could not be ask. |
The cloning is done via http/https in this case, not ssh. Drone always provides an auth token, even for public repos (see my commit linked for details). Maybe this token was completely missing in your tests when http/s worked? The "main" repo itself is cloned just fine up until that batch lfs request. |
[x]
):Description
I'm using gitea with drone for ci. Up until 1.7.0 everything works fine but with 1.7.0 rc1/rc2 repositories with lfs cannot be cloned by drone. The repo is public but it fails with an authorization error.
Switching the binary back to 1.6.3 fixes everything again (keeping the same database, repos, config, etc that 1.7.0 used).
Edit:
This request returns 200 before 1.7.0, 401 in 1.7.0:
The text was updated successfully, but these errors were encountered: