Unable to display complete avatar

[seepine]

Description

Unable to display complete avatar, the avatar class of object-fit is contain.

GitHub can display the complete avatar because when GitHub changes the avatar, it must be cropped.

Maybe set the avatar class of object-fit : cover for the better.

Gitea Version

1.22.0

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Git Version

No response

Operating System

No response

How are you running Gitea?

docker

Database

None

[silverwind]

As per #31991 (review), I think contain is better because cover may crop non-square images incorrectly.

Proper solution will be to present the user a UI to crop the avatar image themselves before upload.

We should ensure that this future image cropping functionality can handle all supported formats like webp, so ideally a webp should upload as webp after cropping, but conversion to png may be acceptable as well.

[yp05327]

I prefer all avatars have same size, not based on the size of uploaded images.
Of cause, cropping image feature is needed, but it can not/ has no effect to the existing avatars.
So he want to fix these existing avatars, not the avatars user will upload in the future.
So even you added cropping image feature, I don't think this issue has been completely fixed.
Are there any other solutions instead of using cover?

[seepine]

I prefer all avatars have same size, not based on the size of uploaded images. Of cause, cropping image feature is needed, but it can not/ has no effect to the existing avatars. So he want to fix these existing avatars, not the avatars user will upload in the future. So even you added cropping image feature, I don't think this issue has been completely fixed. Are there any other solutions instead of using cover?

Yes I completely agree.