Update Note and Warning markdown highlighting with GitHub's changes #28316
Labels
type/proposal
The new feature has not been accepted yet but needs to be discussed first.
Comments
yardenshoham
added
the
type/proposal
|
So, If I understand correctly, GitHub no longer supports Instead, it uses That's a breaking change. Should we follow what GitHub did? |
|
I think we should follow GitHub on this feature |
This was referenced Feb 3, 2024
lafriks
pushed a commit
that referenced
this issue
Feb 10, 2024
- Follows #21711 - Closes #28316 Implement GitHub's alert blocks markdown feature Docs: - https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts - https://github.com/orgs/community/discussions/16925 ### Before  ### After  ##⚠️ BREAKING⚠️ The old syntax no longer works How to migrate: If you used ```md > **Note** My note ``` Switch to ```md > [!NOTE] > My note ``` --------- Signed-off-by: Yarden Shoham <[email protected]> Co-authored-by: silverwind <[email protected]> Co-authored-by: Giteabot <[email protected]>
DennisRasey
pushed a commit
to DennisRasey/forgejo
that referenced
this issue
Feb 18, 2024
- Follows go-gitea/gitea#21711 - Closes go-gitea/gitea#28316 Implement GitHub's alert blocks markdown feature Docs: - https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts - https://github.com/orgs/community/discussions/16925 ### Before  ### After  ##⚠️ BREAKING⚠️ The old syntax no longer works How to migrate: If you used ```md > **Note** My note ``` Switch to ```md > [!NOTE] > My note ``` --------- Signed-off-by: Yarden Shoham <[email protected]> Co-authored-by: silverwind <[email protected]> Co-authored-by: Giteabot <[email protected]>
silverwind
added a commit
to silverwind/gitea
that referenced
this issue
Feb 20, 2024
- Follows go-gitea#21711 - Closes go-gitea#28316 Implement GitHub's alert blocks markdown feature Docs: - https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts - https://github.com/orgs/community/discussions/16925 ### Before  ### After  ##⚠️ BREAKING⚠️ The old syntax no longer works How to migrate: If you used ```md > **Note** My note ``` Switch to ```md > [!NOTE] > My note ``` --------- Signed-off-by: Yarden Shoham <[email protected]> Co-authored-by: silverwind <[email protected]> Co-authored-by: Giteabot <[email protected]>
|
Automatically locked because of our CONTRIBUTING guidelines |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Feature Description
Since July 21st, GitHub has made a few changes to their feature. We introduced it into Gitea with #21711. Now we need to update the implementation to match GitHub's, including a syntax change. An example of the current implementation on GitHub:
Note
Highlights information that users should take into account, even when skimming.
Tip
Optional information to help a user be more successful.
Important
Crucial information necessary for users to succeed.
Warning
Critical content demanding immediate user attention due to potential risks.
Caution
Negative potential consequences of an action.
Docs: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#alerts https://github.com/orgs/community/discussions/16925
Screenshots
No response
The text was updated successfully, but these errors were encountered: