make clean downloads all dependencies

[strk]

Description

Running make clean downloads all dependencies. I don't think it should hit the net.

Gitea Version

current main branch as of 6c501b1

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

not running it

Database

None

[BaiZe1998]

can u replicate this and show us the logs

[lng2020]

That seems to be an upstream issue about go clean. Because here we simply use go clean -i ./...
some related discussion(golang/go#32977)

[silverwind]

There is no clear definition on what a clean shall do, but we do have clean and clean-all, so could maybe move the network stuff to clean-all.

[delvh]

Why should clean do network stuff?
That's not its task.

[silverwind]

Do we actually need this go clean? From go help clean:

Clean removes object files from package source directories.
The go command builds most objects in a temporary directory,
so go clean is mainly concerned with object files left by other
tools or by manual invocations of go build.

If a package argument is given or the -i or -r flag is set,
clean removes the following files from each of the
source directories corresponding to the import paths:

	_obj/            old object directory, left from Makefiles
	_test/           old test directory, left from Makefiles
	_testmain.go     old gotest file, left from Makefiles
	test.out         old test log, left from Makefiles
	build.out        old test log, left from Makefiles
	*.[568ao]        object files, left from Makefiles

	DIR(.exe)        from go build
	DIR.test(.exe)   from go test -c
	MAINFILE(.exe)   from go build MAINFILE.go
	*.so             from SWIG

Maybe it's good for go generate bindata files? But I don't think there is anything else temporary inside the project source dirs and those bindata files could be deleted via rm as well.

[techknowlogick]

Thanks @silverwind, I've created a PR based on your research