Test Delivery for inactive webhook behaves confusing
#26824
Labels
type/proposal
The new feature has not been accepted yet but needs to be discussed first.
Comments
Young-Lord
added
the
type/proposal
silverwind
pushed a commit
that referenced
this issue
Sep 25, 2023
…inactive (#27211) These buttons are now disabled when the webhook is not active. The buttons were always enabled before this change. - Fixes #26824 - Replaces #26814 # Before   # After   Signed-off-by: Yarden Shoham <[email protected]>
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this issue
Sep 25, 2023
…inactive (go-gitea#27211) These buttons are now disabled when the webhook is not active. The buttons were always enabled before this change. - Fixes go-gitea#26824 - Replaces go-gitea#26814 # Before   # After   Signed-off-by: Yarden Shoham <[email protected]>
lunny
pushed a commit
that referenced
this issue
Sep 25, 2023
…inactive (#27211) (#27253) Backport #27211 by @yardenshoham These buttons are now disabled when the webhook is not active. The buttons were always enabled before this change. - Fixes #26824 - Replaces #26814 # Before   # After   Signed-off-by: Yarden Shoham <[email protected]> Co-authored-by: Yarden Shoham <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Feature Description
Currently, when user click
Test Deliveryfor an inactivate webhook, Gitea will refuse to send the webhook. However, theResponseor anywhere else (except log on server) doesn't describe the reason, and may make user think that the webhook server is crashed.It would be great if a friendly notice was shown in
Response column.see PR #26814
Screenshots
Current behavior
Expected behavior
The text was updated successfully, but these errors were encountered: