Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org team users who have wiki write permission can not delete wiki page #24125

Closed
yp05327 opened this issue Apr 14, 2023 · 0 comments · Fixed by #24274
Closed

Org team users who have wiki write permission can not delete wiki page #24125

yp05327 opened this issue Apr 14, 2023 · 0 comments · Fixed by #24274
Labels
Milestone

Comments

@yp05327
Copy link
Contributor

yp05327 commented Apr 14, 2023

Description

Background error:
image

If users also have code write permission, they can delete wiki pages.
So delete wiki pages needs write permission of both Code and Wiki.

But users can create/edit wiki page if they have only wiki write permission.
Backend only check wiki write permission:
image
Have no idea about the correct design.

Gitea Version

1.20.0+dev-449-g8d21b6925

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

gitea.com

Database

None

@lunny lunny added this to the 1.19.2 milestone Apr 15, 2023
silverwind added a commit that referenced this issue Apr 23, 2023
GiteaBot added a commit to GiteaBot/gitea that referenced this issue Apr 23, 2023
silverwind added a commit that referenced this issue Apr 24, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants