When LFS/packages are disabled, gitea dump exits with error and gitea doctor --all logs errors #23622
Comments
lunny
added a commit
that referenced
this issue
Mar 23, 2023
Close #23622 As described in the issue, disabling the LFS/Package settings will cause errors when running `gitea dump` or `gitea doctor`. We need to check the settings and the related operations should be skipped if the settings are disabled. Co-authored-by: Lunny Xiao <[email protected]>
Zettat123
added a commit
to Zettat123/gitea
that referenced
this issue
Mar 27, 2023
Close go-gitea#23622 As described in the issue, disabling the LFS/Package settings will cause errors when running `gitea dump` or `gitea doctor`. We need to check the settings and the related operations should be skipped if the settings are disabled. Co-authored-by: Lunny Xiao <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
My /etc/gitea/app.ini contains the following to disable LFS and packages:
gitea dump
When running the following dump command (from within a systemd unit running as the same user as the gitea process, everything is set up properly on that end), the dump appears to successfully create a backup archive, but the process logs errors and more importantly, exits non-zero.
Here is the log taken from journalctl output:
A workaround I am using now is to add
--skip-lfs-data --skip-package-datato the dump command.gitea doctor
A similar but not identical issue exists for the following gitea doctor command, where it logs errors but does exit zero:
Log output:
There is no convenient workaround that eliminates the ERRORs from the log, but it's acceptable because I have to manually inspect the log anyway, and at least the process doesn't exit non-zero.
Expectations/desired behavior
The reason I think this is a bug, is that certainly for dump, I don't think any valid configuration should cause a standard
gitea dumpcommand to fail. It should not be necessary for the standard dump command to be modified just because of config.IMO the same applies for
gitea doctor --all, ideally it would mark as SKIP or even OK any tests that only ERROR because the relevant feature is turned off.Also important to note, that this did not occur in 1.18.x versions.
Gitea Version
Gitea version 1.19.0 built with GNU Make 4.1, go1.20.2 : bindata, sqlite, sqlite_unlock_notify
Can you reproduce the bug on the Gitea demo site?
No
Log Gist
No response
Screenshots
No response
Git Version
git version 2.39.2
Operating System
Debian GNU/Linux 11 (bullseye)
How are you running Gitea?
Running the latest pre-built x86_64 release from go-gitea/gitea releases (i.e., using one of your downloads).
Running gitea itself in a systemd unit, and running both the backup and doctor commands in systemd units as well.
The gitea unit is primarily:
The backup and doctor units are essentially the same basic structure.
Database
SQLite
The text was updated successfully, but these errors were encountered: