Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile navbar menu toggle not focusable with TAB sequences #23053

Closed
fsologureng opened this issue Feb 22, 2023 · 4 comments
Closed

Mobile navbar menu toggle not focusable with TAB sequences #23053

fsologureng opened this issue Feb 22, 2023 · 4 comments
Labels
Milestone

Comments

@fsologureng
Copy link
Contributor

Description

A person with screen reader over a mobile can't access to their own profile or to the Create button.

This can be checked with mobile emulation in a browser without a screen reader.

Gitea Version

Codeberg

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

Capture with focus in previous tabindex element

Capture after pressing TAB

Git Version

No response

Operating System

No response

How are you running Gitea?

https://try.gitea.io

Database

None

@HesterG
Copy link
Contributor

HesterG commented Feb 22, 2023

I can see that the menu button on the right of the nav bar is not reachable by pressing tab. But i am not very sure which is the create button, is it "run the binary" link?

@wxiaoguang
Copy link
Contributor

wxiaoguang commented Feb 22, 2023

The requirement behind this issue is: click the Create button to create new repositories.

image

@HesterG
Copy link
Contributor

HesterG commented Feb 22, 2023

I think this might be a problem with accessibility. Right now the menu button is not accessible by keyboard, leading to the inaccessiblity of buttons inside the menu like Create button.

jolheiser pushed a commit that referenced this issue Feb 22, 2023
This PR is trying to add accessibility to the menu as mentioned in
#23053 so the menu can be accessed using keyboard (A quick demo is added
below), with a reference to
[PR2612](#22612). The goal is to
make the menu accessible merely using keyboard like shown below. And
this PR might need confirmation from developers using screen readers.
@lunny
Copy link
Member

lunny commented Feb 23, 2023

Fixed by #23059

@lunny lunny closed this as completed Feb 23, 2023
@lunny lunny added this to the 1.19.0 milestone Feb 23, 2023
HesterG added a commit to HesterG/gitea that referenced this issue Feb 23, 2023
This PR is trying to add accessibility to the menu as mentioned in
go-gitea#23053 so the menu can be accessed using keyboard (A quick demo is added
below), with a reference to
[PR2612](go-gitea#22612). The goal is to
make the menu accessible merely using keyboard like shown below. And
this PR might need confirmation from developers using screen readers.
lunny pushed a commit that referenced this issue Feb 23, 2023
Backport #23059

This PR is trying to add accessibility to the menu as mentioned in
#23053 so the menu can be accessed using keyboard (A quick demo is added
below), with a reference to
[PR2612](#22612). The goal is to
make the menu accessible merely using keyboard like shown below. And
this PR might need confirmation from developers using screen readers.
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants