Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Topic selection slow on Codeberg and WebKit #22238

Closed
tallship opened this issue Dec 25, 2022 · 2 comments · Fixed by #30127
Closed

Topic selection slow on Codeberg and WebKit #22238

tallship opened this issue Dec 25, 2022 · 2 comments · Fixed by #30127
Labels

Comments

@tallship
Copy link
Contributor

Description

On sites like codeberg with ~1e4 topics, on several web browsers (we have reports for luakit (webkit-based) and firefox), topic selection becomes impossibly slow as the pop-up box is populated with the 1e4 elements for the topics.

Arguably, this is also a UX issue; nobody would want to scroll through the 1e4 topics, in particular as the order is not (really) predictable for users and prone to change as the popularity of topics changes. Hence: would it be possible to just limit the number of matches from topics/search?

Browser version: luakit 2.3.3

Gitea Version

See https://codeberg.org/

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

(sorry, this would be a video)

Git Version

See https://codeberg.org/

Operating System

Debian Bullseye

How are you running Gitea?

See https://codeberg.org/

Firefox luakit 2.3.3

Database

PostgreSQL

@fsologureng
Copy link
Contributor

Hi, I can confirm this. The ajax request just took ~350ms, so it is a problem in the response handler.

Additionally, maybe the call should be done just once the value in the input has a minimum length.

Originally reported in https://codeberg.org/forgejo/forgejo/issues/132

@jolheiser
Copy link
Member

I think a minimal length might be good, a limit to returned topics, and certainly a debounce if there is none already.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants