UI: button to download code lacks tooltip

[pmattern]

• Gitea version (or commit ref): cb16028
• Git version: 2.10.2
• Operating system: Arch Linux
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • SQLite

Within those fields displaying a repository's URL which can e. g. be seen at URLs like gitea.example.org/Someorganization/Somerepo the button to copy comes with a tooltip while the button to download at its right doesn't.

Maybe this is a bit of bikeshedding but I figure the UX would be a bit more smooth if the button to download had a tooltip as well.

[strk]

Sounds like an easy change. Are you up for a PR @pmattern ?

[gencer]

@pmattern try github theme for a while. I fixed these things. Hope to see theme feature on gitea in the future. https://github.com/gencer/gitea-gihubify

[tboerger]

@pmattern try github theme for a while. I fixed these things. Hope to see theme feature on gitea in the future. https://github.com/gencer/gitea-gihubify

Cool, we will provide better theming support for sure, but we will never get a GitHub clone theme into the core itself, we don't want to end like https://gitbucket.github.io/gitbucket-news/gitbucket/2016/03/20/change-user-interface.html ;)

[pmattern]

@gencer
After applying gencer/gitea-githubify@8b80e49 upon 574e49c the problem addressed in this issue is persisting here.
Btw. files patch{,-ext}.css have to go to public/*css*/, not? Also, I wonder whether directory ss really isn't needed at all and whether it's unavoidable that patch.css is basically a single line comprising 300k characters.

@strk

Sounds like an easy change. Are you up for a PR @pmattern ?

Unfortunately I'm lacking both time and skills right now.

[lunny]

@pmattern, please confirm this have been resolved.

[pmattern]

Running 39d0db5 the problem is basically solved but there are two things worth having another look at, IMO:

The tooltip to copy is above that line comprising URL etc. as shown above while the tooltip to download is placed left of the button which is a bit inconsistent and covering parts of the URL.

More importantly string "download_archive" doesn't seem like a really good choice.

[lunny]

@hhenkel

[tboerger]

Looks like the bindata have not been updated.

And the tooltip is automatically placed like that.

[pmattern]

And the tooltip is automatically placed like that.

Indeed the alignment seems to be independent from the current commits. Increasing the width of the browser window yields

Not sure whether the underlying algorithms should be adjusted, though. When the tooltip was displayed left of the button plenty of space would have been available to have it placed top / right of that line displaying URL and so on.

[hhenkel]

I'm currently testing - with the position "top right" it looks like shown on my screen.

[hhenkel]

@pmattern I submitted #364 to fix this, can you test it?

[pmattern]

@hhenkel
Running bab737b from current master the tooltip states "Download this repository" and the placement is reasonable, IMO.

Would it make sense to have the other tooltip state something like "Copy URL" or so, hence some kind of description like the one provided by "Download this repository" right now? Just wondering.

[lunny]

@pmattern, please fire another issue for Copy URL and I think this issue could be closed.

[tboerger]

Fixed