Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitea serv to enable partial clones with ssh #21805

Closed
panicking opened this issue Nov 13, 2022 · 3 comments
Closed

gitea serv to enable partial clones with ssh #21805

panicking opened this issue Nov 13, 2022 · 3 comments
Labels
type/bug

Comments

@panicking
Copy link

Description

Ubuntu 22.04 lts

GIT_TRACE=1 git clone --filter=tree:0 ssh://gitea@gitea:38745/common/kernel.git
15:58:08.342028 git.c:455 trace: built-in: git clone --filter=tree:0 ssh://gitea@gitea:38745/common/kernel.git
Cloning into 'kernel'...
15:58:08.348827 run-command.c:668 trace: run_command: unset GIT_DIR; GIT_PROTOCOL=version=2 ssh -o SendEnv=GIT_PROTOCOL -p 38745 [email protected] 'git-upload-pack '''/common/kernel.git''''
warning: filtering not recognized by server, ignoring

Gitea processo during clone

CGroup: /system.slice/gitea.service
         ├─4093562 /opt/gitea/gitea web
         ├─4093737 /usr/bin/git -c protocol.version=2 -c uploadpack.allowfilter=true -c uploadpack.allowAnySHA1InWant=true -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filte>
         ├─4093738 /usr/bin/git -c protocol.version=2 -c uploadpack.allowfilter=true -c uploadpack.allowAnySHA1InWant=true -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filte>
         ├─4093739 /usr/bin/git -c protocol.version=2 -c uploadpack.allowfilter=true -c uploadpack.allowAnySHA1InWant=true -c credential.helper= -c filter.lfs.required= -c filter.lfs.smudge= -c filte>
         └─4093740 /usr/bin/git -c protocol.version=2 -c uploadpack.allowfilter=true

Gitea Version

1.17.3

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Screenshots

No response

Git Version

2.25.1, Wire Protocol Version 2 Enabled

Operating System

ubuntu 22.04 LTS

How are you running Gitea?

gitea is official run from systemd on kvm machine not docker

Database

PostgreSQL
@zeripath
Copy link
Contributor

Works for me on 1.18-rc0 and dev.

@zeripath
Copy link
Contributor

OK I've been able to replicate on 1.17.3 docker. This is odd.

zeripath added a commit to zeripath/gitea that referenced this issue Nov 13, 2022
@zeripath
Fix enabling partial clones on 1.17
0c9418e 
When backporting go-gitea#20902 in go-gitea#21058 there was a slight misbackport. It was missed that we needed
to remove the global command option before setting the settings.

Fix go-gitea#21805

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this issue Nov 13, 2022
Merged
@zeripath
Copy link
Contributor

Aha! I've discovered the issue. The backport was broken.

lunny pushed a commit that referenced this issue Nov 14, 2022
@zeripath
Fix enabling partial clones on 1.17 (#21809)
65b5c8e 
When backporting #20902 in #21058 there was a slight misbackport. It was
missed that we needed to remove the global command option before setting
the settings.

Fix #21805

Signed-off-by: Andrew Thornton <[email protected]>
@KN4CK3R KN4CK3R closed this as completed Nov 16, 2022
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@KN4CK3R @zeripath @panicking