Jump to Line Fragment Should Ignore Line Numbers < 1 #21722
Labels
issue/confirmed
Issue has been reviewed and confirmed to be present or accepted to be implemented
type/bug
Comments
silverwind
added
the
issue/confirmed
|
Reproduces on try.gitea.io as well: https://try.gitea.io/silverwind/symlink-test/src/branch/master/test.txt#L0 Hitting the back button on the page produces more errors. |
|
@silverwind Thanks for addressing this so quickly! |
silverwind
added a commit
to silverwind/gitea
that referenced
this issue
Nov 8, 2022
lunny
added a commit
that referenced
this issue
Nov 11, 2022
Fixes: #21722 Co-authored-by: Lunny Xiao <[email protected]>
silverwind
added a commit
to silverwind/gitea
that referenced
this issue
Nov 11, 2022
Fixes: go-gitea#21722 Co-authored-by: Lunny Xiao <[email protected]>
silverwind
added a commit
to silverwind/gitea
that referenced
this issue
Nov 11, 2022
Fixes: go-gitea#21722 Co-authored-by: Lunny Xiao <[email protected]>
lunny
added a commit
that referenced
this issue
Nov 11, 2022
Backport #21728 Fixes: #21722 Co-authored-by: Lunny Xiao <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
When calling https://codeberg.org/Codeberg/gitea/src/branch/codeberg-1.17/README.md?display=source#L0 it is internally redirected to https://codeberg.org/Codeberg/gitea/src/branch/codeberg-1.17/README.md?display=source#undefined
which leads to the following javascript error:
Maybe line numbers < 1 can simply be ignored as github does:
https://github.com/go-gitea/gitea/blob/main/README.md?plain=1#L0
This would fix issues with links from external systems that don't check the line number properly.
Gitea Version
1.17.3
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
No response
Git Version
No response
Operating System
No response
How are you running Gitea?
helm chart
Database
PostgreSQL
The text was updated successfully, but these errors were encountered: