Regression for width on pull request #21460
Labels
Comments
|
Yes I think we should restore old width again. Only split diffs need more width, but I think that was already handled previously. |
Gusted
pushed a commit
to Gusted/gitea
that referenced
this issue
Oct 15, 2022
- Revert a behavior from go-gitea#21012, which liberally added `fluid padded` to non-split style pull pages, this caused it to take up the whole screen(such in split-style pull pages) on pull pages where the diff was shown. - Resolves go-gitea#21460
zeripath
pushed a commit
that referenced
this issue
Oct 19, 2022
- Revert a behavior from #21012, which liberally added `fluid padded` to non-split style pull pages, this caused it to take up the whole screen(such in split-style pull pages) on pull pages where the diff was shown. - Resolves #21460 ### Before   ### After  
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
It seems like that there is a regression since #21012, which added
fluid paddedclasses, regardless of split mode being enabled. This is causing the whole UI to take up all the available width, is this something we really want? In my eyes this seems like a regression/bug, it might make sense for the diff to be full-width(we are copying Github's behavior??) but not the other elements, which is currently happening.CC @silverwind
Gitea Version
94d6d93
Can you reproduce the bug on the Gitea demo site?
Yes
Log Gist
No response
Screenshots
Git Version
No response
Operating System
No response
How are you running Gitea?
Not relevant
Database
SQLite
The text was updated successfully, but these errors were encountered: