Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When there's a huge file, escapeStreamer.Text will be very slow #20939

Closed
wolfogre opened this issue Aug 24, 2022 · 0 comments · Fixed by #20940
Closed

When there's a huge file, escapeStreamer.Text will be very slow #20939

wolfogre opened this issue Aug 24, 2022 · 0 comments · Fixed by #20940
Labels
skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Milestone
1.18.0

Comments

@wolfogre
Copy link
Member

Description

When there's a huge file, escapeStreamer.Text will be very slow.

Gitea Version

103b94f

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

Run ./gitea on linux.

Database

MySQL
@wolfogre wolfogre mentioned this issue Aug 24, 2022
Merged
@lunny lunny added this to the 1.18.0 milestone Aug 24, 2022
@lunny lunny added the skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. label Aug 24, 2022
zeripath pushed a commit that referenced this issue Aug 24, 2022
@wolfogre
Avoid frequent string2bytes conversions (#20940)
15b189b 
Fix #20939
vsysoev pushed a commit to IntegraSDL/gitea that referenced this issue Aug 28, 2022
@wolfogre
Avoid frequent string2bytes conversions (go-gitea#20940)
1c35f08 
Fix go-gitea#20939
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. type/bug
Projects
None yet
Milestone
1.18.0
Development

Successfully merging a pull request may close this issue.

fix: avoid frequent string2bytes conversions
2 participants
@lunny @wolfogre