Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The display problem of the small bell in the mobile phone #20069

Closed
tyroneyeh opened this issue Jun 21, 2022 · 0 comments · Fixed by #20108
Closed

The display problem of the small bell in the mobile phone #20069

tyroneyeh opened this issue Jun 21, 2022 · 0 comments · Fixed by #20108
Labels
topic/mobile topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.
Milestone
1.18.0

Comments

@tyroneyeh
Copy link
Contributor

Feature Description

The small bell is not obvious enough when browsing with a mobile phone

Screenshots

As is:
gitea-mobile-notify

Suggest:
gitea-mobile-notify-new
@tyroneyeh tyroneyeh added type/feature Completely new functionality. Can only be merged if feature freeze is not active. type/proposal The new feature has not been accepted yet but needs to be discussed first. labels Jun 21, 2022
tyroneyeh added a commit to tyroneyeh/gitea that referenced this issue Jun 23, 2022
@tyroneyeh
Adjust template for go-gitea#20069 smallbell
8accfa6
@tyroneyeh tyroneyeh mentioned this issue Jun 23, 2022
Merged
@lunny lunny added topic/ui Change the appearance of the Gitea UI and removed type/feature Completely new functionality. Can only be merged if feature freeze is not active. labels Jun 24, 2022
lunny added a commit that referenced this issue Jul 4, 2022
@tyroneyeh @wxiaoguang
@lunny @6543
Adjust template for #20069 smallbell (#20108)
c174bdc 
* Adjust template for #20069 smallbell

* Adjust notification Unread Count variable to global and count bell position with mobile

* Adjust bell icon style

* Adjust smallbell to middle

* Avoid using inline styles

* move notificationUnreadCount to a general code block, reduce changed lines

* Solved conflicts

Co-authored-by: wxiaoguang <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: 6543 <[email protected]>
@tyroneyeh tyroneyeh mentioned this issue Jul 5, 2022
Merged
zeripath added a commit to zeripath/gitea that referenced this issue Jul 5, 2022
@zeripath
Refix notification bell placement
bf88c94 
The use of `m-4 text black` for the notification bell results in this
icon being shifted upwards. Instead we should use the `item` class but
adjust `not-mobile` and `mobile-only` to make their `display: none`
settings `!important`.

(As an aside: This is probably one of the only times we should use
`!important` in our less files and the rest should be avoided or
removed.)

Ref go-gitea#20069
Revert go-gitea#20236

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this issue Jul 5, 2022
Merged
zeripath added a commit that referenced this issue Jul 6, 2022
@zeripath
Refix notification bell placement (#20251)
1e43a88 
The use of `m-4 text black` for the notification bell results in this
icon being shifted upwards. Instead we should use the `item` class but
adjust `not-mobile` and `mobile-only` to make their `display: none`
settings `!important`.

(As an aside: This is probably one of the only times we should use
`!important` in our less files and the rest should be avoided or
removed.)

Ref #20069
Revert #20236

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added this to the 1.18.0 milestone Jul 6, 2022
zjjhot added a commit to zjjhot/gitea that referenced this issue Jul 7, 2022
@zjjhot
Merge remote-tracking branch 'upstream/main'
310604f 
* upstream/main:
  Modify milestone search keywords to be case insensitive (go-gitea#20266)
  Fix toolip on mobile notification bell (go-gitea#20270)
  Allow RSA 2047 bit keys (go-gitea#20272)
  Refix notification bell placement (go-gitea#20251)
  Bump mermaid from 9.1.1 to 9.1.2 (go-gitea#20256)
  EscapeFilter the group dn membership (go-gitea#20200)
  Only show Followers that current user can access (go-gitea#20220)
  Init popup for new code comment (go-gitea#20234)
  Bypass Firefox (iOS) bug (go-gitea#20244)
  Adjust max-widths for the repository file table (go-gitea#20243)
  Display full name (go-gitea#20171)
  Adjust class for mobile has the problem of double small bells (go-gitea#20236)
  Adjust template for go-gitea#20069 smallbell (go-gitea#20108)
  Add integration tests for the Gitea migration form (go-gitea#20121)
  Allow dev i18n to be more concurrent (go-gitea#20159)
  Allow enable LDAP source and disable user sync via CLI (go-gitea#20206)
dineshsalunke pushed a commit to dineshsalunke/gitea that referenced this issue Jul 9, 2022
@tyroneyeh @wxiaoguang
@lunny @6543 @dineshsalunke
Adjust template for go-gitea#20069 smallbell (go-gitea#20108)
3814116 
* Adjust template for go-gitea#20069 smallbell

* Adjust notification Unread Count variable to global and count bell position with mobile

* Adjust bell icon style

* Adjust smallbell to middle

* Avoid using inline styles

* move notificationUnreadCount to a general code block, reduce changed lines

* Solved conflicts

Co-authored-by: wxiaoguang <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: 6543 <[email protected]>
dineshsalunke pushed a commit to dineshsalunke/gitea that referenced this issue Jul 9, 2022
@zeripath @dineshsalunke
Refix notification bell placement (go-gitea#20251)
957836f 
The use of `m-4 text black` for the notification bell results in this
icon being shifted upwards. Instead we should use the `item` class but
adjust `not-mobile` and `mobile-only` to make their `display: none`
settings `!important`.

(As an aside: This is probably one of the only times we should use
`!important` in our less files and the rest should be avoided or
removed.)

Ref go-gitea#20069
Revert go-gitea#20236

Signed-off-by: Andrew Thornton <[email protected]>
vsysoev pushed a commit to IntegraSDL/gitea that referenced this issue Aug 10, 2022
@tyroneyeh @wxiaoguang
@lunny @6543
Adjust template for go-gitea#20069 smallbell (go-gitea#20108)
6c849d5 
* Adjust template for go-gitea#20069 smallbell

* Adjust notification Unread Count variable to global and count bell position with mobile

* Adjust bell icon style

* Adjust smallbell to middle

* Avoid using inline styles

* move notificationUnreadCount to a general code block, reduce changed lines

* Solved conflicts

Co-authored-by: wxiaoguang <[email protected]>
Co-authored-by: Lunny Xiao <[email protected]>
Co-authored-by: 6543 <[email protected]>
vsysoev pushed a commit to IntegraSDL/gitea that referenced this issue Aug 10, 2022
@zeripath
Refix notification bell placement (go-gitea#20251)
e7c0265 
The use of `m-4 text black` for the notification bell results in this
icon being shifted upwards. Instead we should use the `item` class but
adjust `not-mobile` and `mobile-only` to make their `display: none`
settings `!important`.

(As an aside: This is probably one of the only times we should use
`!important` in our less files and the rest should be avoided or
removed.)

Ref go-gitea#20069
Revert go-gitea#20236

Signed-off-by: Andrew Thornton <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/mobile topic/ui Change the appearance of the Gitea UI type/proposal The new feature has not been accepted yet but needs to be discussed first.
Projects
None yet
Milestone
1.18.0
Development

Successfully merging a pull request may close this issue.

Make notification bell more prominent on mobile tyroneyeh/gitea
4 participants
@lunny @tyroneyeh @zeripath @Gusted