Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken icon image for Google OAuth2 provider #18494

Closed
kvaster opened this issue Jan 31, 2022 · 0 comments · Fixed by #18504
Closed

Broken icon image for Google OAuth2 provider #18494

kvaster opened this issue Jan 31, 2022 · 0 comments · Fixed by #18504
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented

Comments

@kvaster
Copy link
Contributor

kvaster commented Jan 31, 2022

Gitea Version

1.16.0

Git Version

No response

Operating System

No response

How are you running Gitea?

Built myself from v1.16.0 tag using golang 1.17.6

Database

No response

Can you reproduce the bug on the Gitea demo site?

No

Log Gist

No response

Description

Google image icon is broken after this PR: #16544

Google provider's name is 'gplus' traditionally and SimpleProvider creates icon image url using name. But no gplus.png is available - only google.png is available.

Screenshots

image

Gusted pushed a commit to Gusted/gitea that referenced this issue Jan 31, 2022
- Use `ImagedProvider` for gplus' oauthv2 provider, as the image isn't
"gplus.png" but "google.png".
- Resolves go-gitea#18494
@Gusted Gusted added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jan 31, 2022
6543 pushed a commit that referenced this issue Feb 1, 2022
Use `ImagedProvider` for gplus' oauthv2 provider, as the image isn't "gplus.png" but "google.png".

Resolves #18494
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
Use `ImagedProvider` for gplus' oauthv2 provider, as the image isn't "gplus.png" but "google.png".

Resolves go-gitea#18494
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants