Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review comment cannot be edited #17768

Closed
jpraet opened this issue Nov 22, 2021 · 3 comments · Fixed by #18323
Closed

Review comment cannot be edited #17768

jpraet opened this issue Nov 22, 2021 · 3 comments · Fixed by #18323
Labels
type/bug
Milestone
1.16.0

Comments

@jpraet
Copy link
Member

jpraet commented Nov 22, 2021

Gitea Version

1.16.0+dev-581-gbaed01f24

Git Version

No response

Operating System

No response

How are you running Gitea?

try.gitea.io

Database

No response

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

No response

Description

It does not currently seem possible to edit the main comment you can add when submitting a PR review.
Such a comment also does not have the labels (like Poster / Owner), reactions and other actions.

https://try.gitea.io/jpraet-org/test-repo/pulls/2

Screenshots

ok (a regular comment on a PR):
image

not ok (a comment from submitted review cannot be edited):
image

not ok (a comment from submitted review cannot be edited, whereas the individual code comment can be edited):
image
@wxiaoguang
Copy link
Contributor

Is it a regression or an existing problem?

@jpraet
Copy link
Member Author

jpraet commented Nov 23, 2021

Looks like an existing problem / oversight. 1.15.6 also doesn't support it.

@zeripath zeripath added this to the 1.16.0 milestone Jan 17, 2022
@wxiaoguang wxiaoguang mentioned this issue Jan 18, 2022
Merged
@wxiaoguang wxiaoguang linked a pull request Jan 18, 2022 that will close this issue
Fix PR comments UI #18323
Merged
@wxiaoguang
Copy link
Contributor

Fixed in #18323

wxiaoguang added a commit that referenced this issue Jan 18, 2022
@wxiaoguang
Fix PR comments UI (#18323)
84f8ef3 
Closes:
* Review comment cannot be edited #17768
* Changing PR Comment Resolved State Disables Further Changes #18315
Chianina pushed a commit to Chianina/gitea that referenced this issue Mar 28, 2022
@wxiaoguang
Fix PR comments UI (go-gitea#18323)
78e918b 
Closes:
* Review comment cannot be edited go-gitea#17768
* Changing PR Comment Resolved State Disables Further Changes go-gitea#18315
@go-gitea go-gitea locked and limited conversation to collaborators Apr 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
1.16.0
Development

Successfully merging a pull request may close this issue.

Fix PR comments UI wxiaoguang/gitea
3 participants
@zeripath @wxiaoguang @jpraet