Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty loading issue context popup for external issue tracker #17047

Closed
jpraet opened this issue Sep 14, 2021 · 2 comments · Fixed by #17050
Closed

Empty loading issue context popup for external issue tracker #17047

jpraet opened this issue Sep 14, 2021 · 2 comments · Fixed by #17050
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Milestone

Comments

@jpraet
Copy link
Member

jpraet commented Sep 14, 2021

Description

I'm seeing an empty issue context popup that remains loading, when an external issue tracker is configured.
This is since upgrading from 1.14 to 1.15.

Screenshots

image

@jpraet jpraet added type/bug topic/ui Change the appearance of the Gitea UI labels Sep 14, 2021
@zeripath
Copy link
Contributor

zeripath commented Sep 14, 2021

would it be possible to check the web console - there is likely to be an error in there.

@zeripath
Copy link
Contributor

zeripath commented Sep 14, 2021

OK it's likely something to do with:

export default function initContextPopups() {
const refIssues = $('.ref-issue');
if (!refIssues.length) return;
refIssues.each(function () {
const [index, _issues, repo, owner] = $(this).attr('href').replace(/[#?].*$/, '').split('/').reverse();
const el = document.createElement('div');

this shouldn't be firing for external issues - so probably these need to have a different class instead of ref-issue or they need another tag.

zeripath added a commit to zeripath/gitea that referenced this issue Sep 14, 2021
The issues pop-up context cannot work for external issues - therefore do not show
these.

Fix go-gitea#17047

Signed-off-by: Andrew Thornton <[email protected]>
zeripath added a commit that referenced this issue Sep 15, 2021
The issues pop-up context cannot work for external issues - therefore do not show
these.

Fix #17047

Signed-off-by: Andrew Thornton <[email protected]>
zeripath added a commit to zeripath/gitea that referenced this issue Sep 15, 2021
Backport go-gitea#17050

The issues pop-up context cannot work for external issues - therefore do not show
these.

Fix go-gitea#17047

Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath added this to the 1.15.3 milestone Sep 15, 2021
lunny pushed a commit that referenced this issue Sep 15, 2021
Backport #17050

The issues pop-up context cannot work for external issues - therefore do not show
these.

Fix #17047

Signed-off-by: Andrew Thornton <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants