The derived warehouse is converted to an ordinary warehouse, and the derived quantity has not changed

[yixiaco]

• Gitea version 1.15.2:
• Database : MySQL

Screenshots

The derived warehouse was modified by me to a normal warehouse

[noerw]

translation: converting a fork to a standalone repo does not affect the fork counter of the original repo 🙃

[zeripath]

The issue is that:

gitea/routers/web/repo/setting.go

Lines 558 to 564 in 7c84c94

	repo.IsFork = false
	repo.ForkID = 0
	if err := models.UpdateRepository(repo, false); err != nil {
	log.Error("Unable to update repository %-v whilst converting from fork", repo)
	ctx.ServerError("Convert Fork", err)
	return
	}

Does not also call:

		if _, err := sess.Exec("UPDATE `repository` SET num_forks=num_forks-1 WHERE id=?", repo.ForkID); err != nil {
			return fmt.Errorf("decrease fork count: %v", err)
		}

within the transaction that UpdateRepository happens in.

There should be a new function ConvertFromFork within models/repo_*.go that will do the necessary updating of the root repo.

[zeripath]

Or probably better UpdateRepository needs to load and check if the repo has changed and handle the necessary changes itself