-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull requests get a 500 error #16835
Comments
What is interesting here is that the only way this error is reported is if an external renderer is used. What is your app.ini? |
I also met the 500 error problem when I opened the issue page of the repositories. After I remove these configs in app.ini, the 500 error seems to be fixed.
|
Ah as I suspected you have an external renderer for markdown enabled. All of your comments are being rendered through pandoc. OK, this will need some changes. I suspect the simplest thing to do will be to put a fallback context in. |
It is possible for RenderString to be passed to an external renderer if markdown is set to be rendered by an external renderer. No context is currently sent to these meaning that this will error out. Fix go-gitea#16835 Signed-off-by: Andrew Thornton <[email protected]>
Now the other thing I see is that you are using an external renderer simply to provide katex rendering... There's another issue for that - but just quickly what is the minimum syntax you require to stop having to use pandoc for this? If we were to simply provide syntax that would render to |
when I close the ;[markup.markdown]
;ENABLED = true
;FILE_EXTENSIONS = .md,.markdown
;RENDER_COMMAND = pandoc -f markdown -t html --katex I get the config file in gitea doc thank |
* In Render tolerate not being passed a context It is possible for RenderString to be passed to an external renderer if markdown is set to be rendered by an external renderer. No context is currently sent to these meaning that this will error out. Fix #16835 Signed-off-by: Andrew Thornton <[email protected]> * Add Context to Repo calls for RenderString All calls from routers can easily add the context - so add it. Signed-off-by: Andrew Thornton <[email protected]>
* In Render tolerate not being passed a context It is possible for RenderString to be passed to an external renderer if markdown is set to be rendered by an external renderer. No context is currently sent to these meaning that this will error out. Fix go-gitea#16835 Signed-off-by: Andrew Thornton <[email protected]> * Add Context to Repo calls for RenderString All calls from routers can easily add the context - so add it. Signed-off-by: Andrew Thornton <[email protected]>
* In Render tolerate not being passed a context It is possible for RenderString to be passed to an external renderer if markdown is set to be rendered by an external renderer. No context is currently sent to these meaning that this will error out. Fix #16835 Signed-off-by: Andrew Thornton <[email protected]> * Add Context to Repo calls for RenderString All calls from routers can easily add the context - so add it. Signed-off-by: Andrew Thornton <[email protected]> Co-authored-by: zeripath <[email protected]>
[x]
):I find
2021/08/27 15:50:40 ...rs/web/repo/issue.go:1143:ViewIssue() [E] RenderString: RenderContext did not provide context
I dont konk this mens?
Description
...
i creta a Pull requests ,then i open a link ,i get a 500 error
i run
gitea doctor recreate-table
,but it alse get itScreenshots
The text was updated successfully, but these errors were encountered: