Link to user profile in issue list is missing server URL

[steko]

• Gitea version (or commit ref): 1.16.0+dev-116-g274aeb3a9
• Git version: n/a
• Operating system: n/a
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL) https://try.gitea.io/issues (for logged in users with at least one issue) AND https://try.gitea.io/steko/webhook-test/issues/1
  • No

Description

In the issue list, the name of the user who created the issue has a link to the user profile (under the issue title: issue#123 opened 12 hours ago by user). However, the href points to https:// instead of https://<instance.tld>/. This happens both on the user dashboard and the repository issue list. Both are caused by these lines in the issuelist.tmpl file:

gitea/templates/shared/issuelist.tmpl

Lines 57 to 63 in 274aeb3

	{{if .OriginalAuthor }}
	{{$.i18n.Tr .GetLastEventLabelFake $timeStr .OriginalAuthor | Safe}}
	{{else if gt .Poster.ID 0}}
	{{$.i18n.Tr .GetLastEventLabel $timeStr .Poster.HomeLink (.Poster.GetDisplayName | Escape) | Safe}}
	{{else}}
	{{$.i18n.Tr .GetLastEventLabelFake $timeStr (.Poster.GetDisplayName | Escape) | Safe}}
	{{end}}

In the issue page, the same behavior is seen next to the open/closed label.

This seems caused by these lines in view_title.tmpl:

gitea/templates/repo/issue/view_title.tmpl

Lines 92 to 98 in ab77a24

	{{if .Issue.OriginalAuthor }}
	{{$.i18n.Tr "repo.issues.opened_by_fake" $createdStr .Issue.OriginalAuthor | Safe}}
	{{else if gt .Issue.Poster.ID 0}}
	{{$.i18n.Tr "repo.issues.opened_by" $createdStr .Issue.Poster.HomeLink (.Issue.Poster.GetDisplayName|Escape) | Safe}}
	{{else}}
	{{$.i18n.Tr "repo.issues.opened_by_fake" $createdStr (.Issue.Poster.GetDisplayName|Escape) | Safe}}
	{{end}}

Screenshots

See in the bottom left the URL preview pointing to https://steko instead of https://try.gitea.io/steko

This is the issue page:

[noerw]

I can't reproduce this, also on the try link you provided, probably already fixed?

[steko]

I just checked again on try.gitea.it and I still see the same issue as described, so I wouldn't say it's been fixed.

[noerw]

the link that gets rendered does not contain a domain section, and as such works correctly for me

maybe a browser extension meddles with your links? 🤔

[steko]

Oh no I found the culprit. It's specific to Italian language, the href value is //steko because there's an extra "/" in the translation string. Can I submit a PR directly or do I need to go through Crowdin?

gitea/options/locale/locale_it-IT.ini

Line 1060 in 94f529a

issues.opened_by=aperto %[1]s da <a href="/%[2]s">%[3]s</a>

[steko]

I submitted a proposal for correcting the translation on Crowdin.

[noerw]

Great, I'll close this then

[zeripath]

agh we better backport a fix to 1.15