Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review comments are covered by sticky header when opening direct link #16263

Closed
1 task done
jpraet opened this issue Jun 26, 2021 · 0 comments · Fixed by #16269
Closed
1 task done

Review comments are covered by sticky header when opening direct link #16263

jpraet opened this issue Jun 26, 2021 · 0 comments · Fixed by #16269
Labels
topic/ui Change the appearance of the Gitea UI type/bug

Comments

@jpraet
Copy link
Member

jpraet commented Jun 26, 2021

Description

When navigating directly to a specific review comment link, like https://try.gitea.io/jpraet/test/pulls/9/files#issuecomment-76046, the review comment is covered by the sticky header.

Screenshots

afbeelding

expected:

afbeelding
@jpraet jpraet mentioned this issue Jun 27, 2021
Merged
@noerw noerw added type/bug topic/ui Change the appearance of the Gitea UI labels Jun 27, 2021
zeripath added a commit that referenced this issue Jun 27, 2021
@jpraet @zeripath
Add scroll-margin-top to account for sticky header (#16269)
eee03ae 
Fixes #16263

Co-authored-by: zeripath <[email protected]>
AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this issue Aug 10, 2021
@jpraet @zeripath @AbdulrhmnGhanem
Add scroll-margin-top to account for sticky header (go-gitea#16269)
9f1efe4 
Fixes go-gitea#16263

Co-authored-by: zeripath <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
topic/ui Change the appearance of the Gitea UI type/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add scroll-margin-top to account for sticky header jpraet/gitea
2 participants
@jpraet @noerw