Filtering in Pull Request kept all the time.

[khmarbaise]

• Gitea version (or commit ref): 1.14.0+dev-239-gad2a28862

• Git version: See try.gitea.io (also 1.13.0-rc2)

• Operating system:

  • See try.gitea.io

• Database (use [x]):

  • [x ] PostgreSQL
  • MySQL
  • MSSQL
  • SQLite

• Can you reproduce the bug at https://try.gitea.io:

  • Yes
  • No
    URL to reproduce: https://try.gitea.io/khmtestorga/testrepo/pulls

Description

If you goto the URL for the pull request you see a list (in this case exactly one) of pull request.

Now you can filter those entries by the Type as shown in the image:

After the selection (as shown next) you will not see any entry which is perfectly fine:

But now the problem arises: If you select from the "Type" -> All Issues the result kept empty in contradiction to before cause there was exactly one entry: (See the screen shot):

Any selection of the filters does not change the filter given in the URL (as you can see in the last screen shot) which results in not being able to remove all the filters and going back to the beginning with the plain url https://try.gitea.io/khmtestorga/testrepo/pulls ...which can only be achieved if you manually select a complete different part and going back to pull requests....

The point seemed to be that if I select of "Type" -> "Assigned to you" a parameter assignee=42393 will be added to the URL. But that parameter can not be removed via "Type" -> "All Issues".

This can only be achieved if I select from "Assignee" manually "All Assignees" ...

Selecting the "Type->All Issues" could set the assignee=0 in the URL. This would resolve this inconvenience?

The question is: Is this a bug or intended behaviour?

[jolheiser]

This is a bug.
It happens because in the template we are setting the assignee to the signed in user and it never gets cleared until the URL is changed.

gitea/templates/repo/issue/list.tmpl

Line 96 in ad2a288

<a class="{{if eq .ViewType "assigned"}}active{{end}} item" href="{{$.Link}}?q={{$.Keyword}}&type=assigned&sort={{$.SortType}}&state={{$.State}}&labels={{.SelectLabels}}&milestone={{$.MilestoneID}}&assignee={{.SignedUser.ID}}">{{.i18n.Tr "repo.issues.filter_type.assigned_to_you"}}</a>

What we should do is switch to using the same logic the other filters use

gitea/routers/repo/issue.go

Lines 128 to 135 in ad2a288

	if ctx.IsSigned {
	switch viewType {
	case "created_by":
	posterID = ctx.User.ID
	case "mentioned":
	mentionedID = ctx.User.ID
	}
	}

I should be able to make a PR for this later today (or anyone else is welcome to as well!) 🙂

[khmarbaise]

If it would be ok I would like to take a look.....

[jolheiser]

If it would be ok I would like to take a look.....

Absolutely!