PR options disappears once unchecked. Can not enable Pull Requests again.

[tna76874]

• Gitea version (or commit ref):
• Git version: Gitea Version: 1.14.0+dev-106-g5b2096dd5
• Operating system: docker
• Database (use [x]):
  • PostgreSQL
  • MySQL
  • MSSQL
  • SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (--> just create repo and disable PR in options)
  • No
• Log gist:

Description

1. Enter repository options
2. uncheck "Activate Pull requests"
3. Whole PR option area with all PR-related options are disappearing
4. How to enable PR for repository again?

Screenshots

[jolheiser]

I think this may be caused by #12808

Instead of checking if PRs can be enabled, it now checks if PRs are enabled. (assuming variables are named semantically)

gitea/templates/repo/settings/options.tmpl

Line 287 in 643a0a6

{{if and (not .IsMirror) (.Repository.UnitEnabled $.UnitTypePullRequests)}}

[zeripath]

yup - this should be fixed in the same way as projects bit just above it.

gitea/templates/repo/settings/options.tmpl

Lines 274 to 281 in 643a0a6

	{{$isProjectsEnabled := .Repository.UnitEnabled $.UnitTypeProjects}}
	<div class="inline field">
	<label>{{.i18n.Tr "repo.project_board"}}</label>
	{{if .UnitTypeProjects.UnitGlobalDisabled}}
	<div class="ui checkbox poping up disabled" data-content="{{.i18n.Tr "repo.unit_disabled"}}">
	{{else}}
	<div class="ui checkbox">
	{{end}}

[zeripath]

I suspect that simply changing line 287 to:

{{if not .IsMirror}}

might actually be enough?

[zeripath]

I'll add this change to #13360