Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diffs are rendered incompletely #13248

Closed
1 of 2 tasks
lhinderberger opened this issue Oct 21, 2020 · 0 comments · Fixed by #13249
Closed
1 of 2 tasks

Diffs are rendered incompletely #13248

lhinderberger opened this issue Oct 21, 2020 · 0 comments · Fixed by #13249

Comments

@lhinderberger
Copy link

Parallel discussion at Codeberg: https://codeberg.org/Codeberg/Community/issues/313

Description

Hi everyone!

There seems to be a bug with the rendering of diffs in Gitea. It seems to me that whenever a diff contains an image, the diff is only rendered up to that image and all other files will not be rendered, although present in the commit that is to be displayed.

This can lead to code reviews being prevented, due to maintainers being unable to see the sourcecode (for example: https://codeberg.org/Codeberg/Documentation/pulls/99).

Screenshots

screenshot-gitea
zeripath added a commit to zeripath/gitea that referenced this issue Oct 21, 2020
@zeripath
Also fix go-gitea#13248
c514eb9 
Signed-off-by: Andrew Thornton <[email protected]>
@zeripath zeripath mentioned this issue Oct 21, 2020
Merged
wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf pushed a commit to wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf/gitea that referenced this issue Oct 21, 2020
@zeripath @wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
Also fix go-gitea#13248
21eddad 
Signed-off-by: Andrew Thornton <[email protected]>
techknowlogick pushed a commit that referenced this issue Oct 21, 2020
@zeripath @6543
Fix initial commit page & binary munching problem (#13249)
327f18c 
* Fix initial commit page

Unfortunately as a result of properly fixing ParsePatch the hack that
used git show <initial_commit_id> to get the diff for this failed.

This PR fixes this using the "super-secret" empty tree ref to make the
diff against.

Signed-off-by: Andrew Thornton <[email protected]>

* Also fix #13248

Signed-off-by: Andrew Thornton <[email protected]>

* Update services/gitdiff/gitdiff.go

Co-authored-by: 6543 <[email protected]>
zeripath added a commit to zeripath/gitea that referenced this issue Oct 22, 2020
@zeripath @6543
Fix initial commit page & binary munching problem (go-gitea#13249)
2db010b 
Backport go-gitea#13249

* Fix initial commit page

Unfortunately as a result of properly fixing ParsePatch the hack that
used git show <initial_commit_id> to get the diff for this failed.

This PR fixes this using the "super-secret" empty tree ref to make the
diff against.

Signed-off-by: Andrew Thornton <[email protected]>

* Also fix go-gitea#13248

Signed-off-by: Andrew Thornton <[email protected]>

* Update services/gitdiff/gitdiff.go

Co-authored-by: 6543 <[email protected]>
@zeripath zeripath mentioned this issue Oct 22, 2020
Merged
zeripath added a commit to zeripath/gitea that referenced this issue Oct 22, 2020
@zeripath @6543
Fix initial commit page & binary munching problem (go-gitea#13249)
7bd2f9f 
Backport go-gitea#13249

* Fix initial commit page

Unfortunately as a result of properly fixing ParsePatch the hack that
used git show <initial_commit_id> to get the diff for this failed.

This PR fixes this using the "super-secret" empty tree ref to make the
diff against.

Signed-off-by: Andrew Thornton <[email protected]>

* Also fix go-gitea#13248

Signed-off-by: Andrew Thornton <[email protected]>

* Update services/gitdiff/gitdiff.go

Co-authored-by: 6543 <[email protected]>
@zeripath zeripath mentioned this issue Oct 22, 2020
Merged
zeripath added a commit that referenced this issue Oct 22, 2020
@zeripath @6543
Fix initial commit page & binary munching problem (#13249) (#13258)
d51c574 
Backport #13249

* Fix initial commit page

Unfortunately as a result of properly fixing ParsePatch the hack that
used git show <initial_commit_id> to get the diff for this failed.

This PR fixes this using the "super-secret" empty tree ref to make the
diff against.

Signed-off-by: Andrew Thornton <[email protected]>

* Also fix #13248

Signed-off-by: Andrew Thornton <[email protected]>

* Update services/gitdiff/gitdiff.go

Co-authored-by: 6543 <[email protected]>

Co-authored-by: 6543 <[email protected]>
zeripath added a commit that referenced this issue Oct 22, 2020
@zeripath @6543
Fix initial commit page & binary munching problem (#13249) (#13259)
f1fd8a7 
Backport #13249

* Fix initial commit page

Unfortunately as a result of properly fixing ParsePatch the hack that
used git show <initial_commit_id> to get the diff for this failed.

This PR fixes this using the "super-secret" empty tree ref to make the
diff against.

Signed-off-by: Andrew Thornton <[email protected]>

* Also fix #13248

Signed-off-by: Andrew Thornton <[email protected]>

* Update services/gitdiff/gitdiff.go

Co-authored-by: 6543 <[email protected]>

Co-authored-by: 6543 <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix initial commit page & binary munching problem zeripath/gitea
1 participant
@lhinderberger