Weird behavior when migrating from Github to gitea.com

[j-be]

• Gitea version (or commit ref): 1.13.0+dev-30-gb02d2c377
• Git version: whatever gitea.com runs on
• Operating system: whatever gitea.com runs on
• Database (use [x]): whatever gitea.com runs on
• Can you reproduce the bug at https://try.gitea.io:
  • Yes (provide example URL)
  • No
  • Not relevant

Description

While working on #8380 I migrated https://github.com/go-gitea/test_repo to https://gitea.com/j-be/test_repo/ and took that for unit tests. I am now a bit confused on how some stuff is handled when migrating:

• Reactions:

  • lunny is taken over as UserID: 1, UserName: "lunny", as that user exists on Gitea too
  • mrsdizzie as user in Reactions is migrated as UserID: -1, UserName: "mrsdizzie(github)", which looks really good in the UI, but mrsdizzie would exist on Gitea as well - I guess OIDC is involved here, but how does it know? Do I need to take into account something here as well?

• Review - here is where it gets really confusing:

  • lunny and jolheiser are both taken over as ReviewerID: 0, even though the accounts would exist on gitea.com
  • Reviews from both zeripath and lafriks are suddenly mine (ReviewerID: 5610, ReviewerName: "j-be"), again, even though these users exist on gitea.com

• Release, PullRequest, and Comments thereof are all PublisherID: 5610, PublisherName: "j-be" and PosterID: 5610, PosterName: "j-be", even though they should still be owned by their initial authors.

[lunny]

Because lunny on gitea.com (that's me :)) has binding github login, so we can replace the external account as an internal account, but mrsdizzie hasn't binding github login, so It displayed as external account.

[lunny]

It should be some bug.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

[stale]

This issue has been automatically closed because of inactivity. You can re-open it if needed.