Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark theme rework #11118

Closed
silverwind opened this issue Apr 18, 2020 · 6 comments
Closed

Dark theme rework #11118

silverwind opened this issue Apr 18, 2020 · 6 comments
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality

Comments

@silverwind
Copy link
Member

List of things I plan to do:

  • Remove THEMES option to allow us to easily introduce new themes. This currently acts as a whitelist so new themes can currently not be introduced without a config change and I don't really see a valid reason why admin would want to disable certain themes (theme is a user's choice, not admin's).
  • Figure out webpack multi-stage webpack build where theme generation can run after public files have been written (essentially running webpack twice).
  • Resolve Monochrome color special rule silverwind/remap-css#3 for easy remapping of monochrome colors.
  • Auto-generate arc-green using remap-css.
  • Possibly add new gitea-dark theme.
@guillep2k guillep2k added type/enhancement An improvement of existing functionality topic/ui Change the appearance of the Gitea UI labels Apr 18, 2020
@stale
Copy link

stale bot commented Jun 17, 2020

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

@stale stale bot added the issue/stale label Jun 17, 2020
@silverwind
Copy link
Member Author

Not stale

@stale stale bot removed the issue/stale label Jun 17, 2020
@silverwind silverwind mentioned this issue Jun 17, 2020
Closed
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Jun 18, 2020
silverwind added a commit to silverwind/gitea that referenced this issue Jun 19, 2020
@silverwind
Add automatic theme discovery
c4a2695 
Introduce a new special value '*' for ui.THEMES which will automatically
discover installed themes in bindata, custom folder and regular files.

Ref: go-gitea#11118
@silverwind
Copy link
Member Author

I'm thinking it may be time to put arc-green to the grave once we have the "proper" dark theme and migrate users to that new theme.

@silverwind
Copy link
Member Author

#12448

@yardenshoham
Copy link
Member

@silverwind is this completed?

@silverwind
Copy link
Member Author

No, but I guess part of this stuff is now out of date, so I'll close it. I still would like to make a "darker" dark theme at some point, which should now be very easy since all colors are in variables.

@go-gitea go-gitea locked and limited conversation to collaborators May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented topic/ui Change the appearance of the Gitea UI type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@lunny @silverwind @guillep2k @yardenshoham