404 Not found error on blob_excerpt expansion

[sosak009]

• Gitea version (or commit ref): 1.11.1
• Git version:
• Operating system: Linux
• Database (use [x]):
  • PostgreSQL
• Can you reproduce the bug at https://try.gitea.io:
  • Yes https://try.gitea.io/testinguserXY/my_bugtest/pulls/3#code-preview-26577
• Log gist:

Description

Hi, gitea returns HTTP/404 not found on a blob_excerpt request while trying to expand the code in pull_request/review conversation (as seen on screenshot). This bug is also reproducable in testing gitea environment.

Request URL example:
Request URL: https://try.gitea.io/testinguserXY/my_bugtest/blob_excerpt/?last_left=0&last_right=0&left=35&right=35&left_hunk_size=6&right_hunk_size=7&path=testfile&style=unified&direction=up&anchor=diff-e05fcb614ab36fdee72ee1f2754ed85e2bd0e8d0K35

Thanks in advance

Screenshots

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

[a1012112796]

Sadly, It still exists :(

[stale]

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.

[sosak009]

Issue still present

[zeripath]

I just tried the provided url: https://try.gitea.io/testinguserXY/my_bugtest/pulls/3 and couldn't reproduce.

[zeripath]

@sosak009 what version of Gitea is this present in?

[sosak009]

@sosak009 what version of Gitea is this present in?

I just reproduced it on the try.gitea.io ...

Request URL: https://try.gitea.io/testinguserXY/my_bugtest/blob_excerpt/?last_left=0&last_right=0&left=35&right=35&left_hunk_size=6&right_hunk_size=7&path=testfile&style=unified&direction=up&anchor=diff-e05fcb614ab36fdee72ee1f2754ed85e2bd0e8d0K35
Request Method: GET
Status Code: 404 

[lunny]

@sosak009 Cannot reproduce it on macOS & firefox

[zeripath]

Ah you mean the up arrow on https://try.gitea.io/testinguserXY/my_bugtest/pulls/3#code-preview-26577

[zeripath]

Now the question is what should that arrow do? Should it just redirect to the files page? Should it even exist?

---

I suspect the answer is it shouldn't exist.

[lunny]

Just remove that up arrow.