Fix wrong milestone in webhook message (#11596) (#11612)

Backport of #11596 Signed-off-by: Gary Kim <[email protected]>
go-gitea · May 24, 2020 · a854846 · a854846
1 parent b52e8de
commit a854846
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/models/issue.go b/models/issue.go
@@ -241,7 +241,7 @@ func (issue *Issue) loadReactions(e Engine) (err error) {
 }
 
 func (issue *Issue) loadMilestone(e Engine) (err error) {
-	if issue.Milestone == nil && issue.MilestoneID > 0 {
+	if (issue.Milestone == nil || issue.Milestone.ID != issue.MilestoneID) && issue.MilestoneID > 0 {
 		issue.Milestone, err = getMilestoneByRepoID(e, issue.RepoID, issue.MilestoneID)
 		if err != nil && !IsErrMilestoneNotExist(err) {
 			return fmt.Errorf("getMilestoneByRepoID [repo_id: %d, milestone_id: %d]: %v", issue.RepoID, issue.MilestoneID, err)