Skip to content

Commit

Permalink
Fix diff skipping lines (#13154)
Browse files Browse the repository at this point in the history
* Fix diff skipping lines

ParsePatch previously just skipped all lines that start with "+++ " or "--- "
and makes no attempt to see these lines in context.

This PR rewrites ParsePatch to pay attention to context and position
within a patch, ensuring that --- and +++ are only skipped if
appropriate.

This PR also fixes several issues with incomplete files.

Fix https://codeberg.org/Codeberg/Community/issues/308
Fix #13153

Signed-off-by: Andrew Thornton <[email protected]>

* Add testcase

Signed-off-by: Andrew Thornton <[email protected]>

* fix comment

* simplify error handling

Signed-off-by: Andrew Thornton <[email protected]>

* never return io.EOF

Signed-off-by: Andrew Thornton <[email protected]>

Co-authored-by: Lauris BH <[email protected]>
  • Loading branch information
zeripath and lafriks authored Oct 16, 2020
1 parent b222dbc commit 6bab678
Show file tree
Hide file tree
Showing 2 changed files with 348 additions and 182 deletions.
Loading

0 comments on commit 6bab678

Please sign in to comment.