Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terminal: prompt to kill remote if process exited #1621

Merged
merged 1 commit into from
Jul 17, 2019
Merged

terminal: prompt to kill remote if process exited #1621

merged 1 commit into from
Jul 17, 2019

Conversation

briandealwis
Copy link
Contributor

Fix #1617 by modifying the terminal to prompt the user to kill the remote headless instance if the remote process has exited.

$ dlv connect :59090
Type 'help' for list of commands.
(dlv) c
Process 36365 has exited with status 0
(dlv) exit
Remote process has exited. Would you like to kill the headless instance? [Y/n] y

There doesn't seem to be a clean way to determine whether GetClient() returned an error because ErrProcessExited on the remote or for some other reason.

aarzilli
aarzilli approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@aarzilli aarzilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aarzilli aarzilli mentioned this pull request Jul 17, 2019
Merged
derekparker
derekparker approved these changes Jul 17, 2019
View reviewed changes
Copy link
Member

@derekparker derekparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekparker derekparker merged commit f67239f into go-delve:master Jul 17, 2019
cgxxv pushed a commit to cgxxv/delve that referenced this pull request Mar 25, 2022
@briandealwis @derekparker
terminal: prompt to kill remote if process exited (go-delve#1621)
95d619e
abner-chenc pushed a commit to loongson/delve that referenced this pull request Mar 1, 2024
@briandealwis @abner-chenc
terminal: prompt to kill remote if process exited (go-delve#1621)
f1c3dee
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekparker derekparker derekparker approved these changes

@aarzilli aarzilli aarzilli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

headless multiclient should exit when process dies
3 participants
@briandealwis @aarzilli @derekparker