Skip to content

Commit

Permalink
Makefile: disable testing lldb-server backend on linux with Go 1.14
Browse files Browse the repository at this point in the history
There seems to be some incompatibility with lldb-server version 6.0.0
on linux and Go 1.14.
  • Loading branch information
aarzilli committed Nov 25, 2019
1 parent 6a4ecbc commit 84a50b1
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions scripts/make.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"sort"
"strings"

"github.com/go-delve/delve/pkg/goversion"
"github.com/spf13/cobra"
)

Expand Down Expand Up @@ -70,7 +71,7 @@ func NewMakeCommands() *cobra.Command {
Use the flags -s, -r and -b to specify which tests to run. Specifying nothing is equivalent to:
go run scripts/make.go test -s all -b default
go run scripts/make.go test -s basic -b lldb # if lldb-server is installed
go run scripts/make.go test -s basic -b lldb # if lldb-server is installed and Go < 1.14
go run scripts/make.go test -s basic -b rr # if rr is installed
go run scripts/make.go test -s basic -m pie # only on linux
Expand Down Expand Up @@ -289,7 +290,7 @@ func testCmd(cmd *cobra.Command, args []string) {

fmt.Println("Testing default backend")
testCmdIntl("all", "", "default", "normal")
if inpath("lldb-server") {
if inpath("lldb-server") && !goversion.VersionAfterOrEqual(runtime.Version(), 1, 14) {
fmt.Println("\nTesting LLDB backend")
testCmdIntl("basic", "", "lldb", "normal")
}
Expand Down

0 comments on commit 84a50b1

Please sign in to comment.