New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect job.RunCount() with mutex #375

Merged

JohnRoesler merged 3 commits into go-co-op:main from seunghyupoh3517:runCount-fix

Aug 22, 2022

seunghyupoh3517 commented Aug 15, 2022

What does this do?

Protect job.RunCount() with mutex and prevent the data race condition.

Which issue(s) does this PR fix/relate to?

List any changes that modify/break current functionality

job.RunCount() is being protected by mutex

Have you included tests for your changes?

Did you document any new/modified functionality?

Updated example_test.go
Updated README.md

Notes


          Protect job.RunCount() with mutex

47e4d5f

seunghyupoh3517 marked this pull request as draft

August 15, 2022 13:01

seunghyupoh3517 added 2 commits

August 15, 2022 09:44


          Minor refactor usage in job.RunCount()

906e9eb


          Lower sleeptime in TestScheduler_WaitForSchedules

9ac649d

seunghyupoh3517 marked this pull request as ready for review

August 15, 2022 17:02

Author

seunghyupoh3517 commented Aug 15, 2022

@JohnRoesler Good morning, John! Please take a look - there was data race in job.RunCount() so I added lock to protect the job.runCount along with minor clean up in calculateTotalDayDifference() in scheduler.

seunghyupoh3517 mentioned this pull request

Bump gocron for datarace fix in runCount fluxninja/aperture#108

Merged

JohnRoesler approved these changes

View reviewed changes

Contributor

JohnRoesler commented Aug 22, 2022

Thank you!

JohnRoesler merged commit 0099be0 into go-co-op:main

Author

seunghyupoh3517 commented Aug 22, 2022

Thank you!
Planning on new release soon? :)

Contributor

JohnRoesler commented Aug 22, 2022

sure 👍 v1.16.3

estahn pushed a commit to estahn/k8s-image-swapper that referenced this pull request


          chore(release): 1.3.0 [skip ci]

e314db7

## [1.3.0](v1.2.3...v1.3.0) (2022-09-07)

### 🎉 Features

* cross account caching with role ([#336](#336)) ([98d138e](98d138e))

### ⬆️ Dependencies

* **deps:** bump actions/cache from 3.0.6 to 3.0.8 ([#319](#319)) ([245ab30](245ab30)), closes [#809](#809) [#833](#833) [#810](#810) [#888](https://github.com/estahn/k8s-image-swapper/issues/888) [#891](https://github.com/estahn/k8s-image-swapper/issues/891) [#899](https://github.com/estahn/k8s-image-swapper/issues/899) [#894](https://github.com/estahn/k8s-image-swapper/issues/894)
* **deps:** bump alpine from 3.16.1 to 3.16.2 ([da05fdd](da05fdd))
* **deps:** bump github.com/alitto/pond from 1.8.0 to 1.8.1 ([#342](#342)) ([4e50c28](4e50c28)), closes [alitto/pond#33](alitto/pond#33) [#34](#34) [#32](#32)
* **deps:** bump github.com/aws/aws-sdk-go from 1.44.70 to 1.44.92 ([0f396c5](0f396c5))
* **deps:** bump github.com/aws/aws-sdk-go from 1.44.70 to 1.44.92 ([#338](#338)) ([fa795ae](fa795ae)), closes [#4548](https://github.com/estahn/k8s-image-swapper/issues/4548) [#4546](https://github.com/estahn/k8s-image-swapper/issues/4546) [#4545](https://github.com/estahn/k8s-image-swapper/issues/4545) [#4544](https://github.com/estahn/k8s-image-swapper/issues/4544) [#4543](https://github.com/estahn/k8s-image-swapper/issues/4543) [#4542](https://github.com/estahn/k8s-image-swapper/issues/4542) [#4539](https://github.com/estahn/k8s-image-swapper/issues/4539) [#4536](https://github.com/estahn/k8s-image-swapper/issues/4536) [#4534](https://github.com/estahn/k8s-image-swapper/issues/4534) [#4533](https://github.com/estahn/k8s-image-swapper/issues/4533)
* **deps:** bump github.com/go-co-op/gocron from 1.16.2 to 1.17.0 ([#340](#340)) ([645bef3](645bef3)), closes [go-co-op/gocron#380](go-co-op/gocron#380) [go-co-op/gocron#381](go-co-op/gocron#381) [go-co-op/gocron#375](go-co-op/gocron#375) [#381](#381) [#380](#380) [#375](#375)
* **deps:** bump github.com/gruntwork-io/terratest from 0.40.19 to 0.40.21 ([#334](#334)) ([d0f6c39](d0f6c39)), closes [#1166](https://github.com/estahn/k8s-image-swapper/issues/1166) [#1159](https://github.com/estahn/k8s-image-swapper/issues/1159)
* **deps:** bump github.com/rs/zerolog from 1.27.0 to 1.28.0 ([#339](#339)) ([7fb4ff5](7fb4ff5)), closes [#457](#457) [#416](#416) [#454](#454) [#453](#453) [#383](#383) [#396](#396) [#414](#414) [#415](#415) [#430](#430) [#432](#432)
* **deps:** bump github.com/spf13/viper from 1.12.0 to 1.13.0 ([#341](#341)) ([9b59bd4](9b59bd4)), closes [spf13/viper#1371](spf13/viper#1371) [spf13/viper#1373](spf13/viper#1373) [spf13/viper#1393](spf13/viper#1393) [spf13/viper#1424](spf13/viper#1424) [spf13/viper#1405](spf13/viper#1405) [spf13/viper#1414](spf13/viper#1414) [spf13/viper#1387](spf13/viper#1387) [spf13/viper#1374](spf13/viper#1374) [spf13/viper#1375](spf13/viper#1375) [spf13/viper#1378](spf13/viper#1378) [spf13/viper#1360](spf13/viper#1360) [spf13/viper#1381](spf13/viper#1381) [spf13/viper#1384](spf13/viper#1384) [spf13/viper#1383](spf13/viper#1383) [spf13/viper#1395](spf13/viper#1395) [spf13/viper#1420](spf13/viper#1420) [spf13/viper#1422](spf13/viper#1422) [spf13/viper#1412](spf13/viper#1412) [spf13/viper#1373](spf13/viper#1373) [spf13/viper#1393](spf13/viper#1393) [spf13/viper#1371](spf13/viper#1371) [spf13/viper#1387](spf13/viper#1387) [spf13/viper#1405](spf13/viper#1405) [spf13/viper#1414](spf13/viper#1414)
* **deps:** bump goreleaser/goreleaser-action from 3.0.0 to 3.1.0 ([#328](#328)) ([a8d2dd1](a8d2dd1)), closes [#369](#369) [#357](#357) [#356](#356) [#360](#360) [#359](#359) [#358](#358) [#367](#367) [#369](#369) [#367](#367) [#358](#358) [#359](#359) [#360](#360) [#357](#357) [#356](#356)
* **deps:** bump k8s.io/api from 0.24.3 to 0.25.0 ([#325](#325)) ([ce10907](ce10907)), closes [#111657](https://github.com/estahn/k8s-image-swapper/issues/111657) [#109090](https://github.com/estahn/k8s-image-swapper/issues/109090) [#111258](https://github.com/estahn/k8s-image-swapper/issues/111258) [#111113](https://github.com/estahn/k8s-image-swapper/issues/111113) [#111696](https://github.com/estahn/k8s-image-swapper/issues/111696) [#108692](https://github.com/estahn/k8s-image-swapper/issues/108692)
* **deps:** bump k8s.io/client-go from 0.24.3 to 0.25.0 ([#324](#324)) ([f7c889f](f7c889f))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet