Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduce size of Context struct from 216 bytes to 208 bytes #912

Merged
merged 1 commit into from
May 7, 2024
Merged

reduce size of Context struct from 216 bytes to 208 bytes #912

merged 1 commit into from
May 7, 2024

Conversation

juburr
Copy link
Contributor

@juburr juburr commented May 7, 2024

optimize memory alignment of Context struct

@pkieltyka pkieltyka merged commit ef31c0b into go-chi:master May 7, 2024
16 checks passed
@pkieltyka
Copy link
Member

thanks :) thats a fun one

@VojtechVitek
Copy link
Contributor

every byte counts :) thanks!

dandee
dandee reviewed Jun 18, 2024
View reviewed changes
Copy link

@dandee dandee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It removes original comment that gives insight what this flag does.

BTW: is "methodTyp" type name correct or a typo? Should it read "methodType"?

@pkieltyka
Copy link
Member

its intentional :) just because "type" is a keyword, so just been using "typ", in this case, of course it doesn't apply, but its there for consistency

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dandee dandee dandee left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juburr @pkieltyka @VojtechVitek @dandee