Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree.go: check if ntParam, ntRegexp was found #477

Closed
wants to merge 3 commits into from
Closed

tree.go: check if ntParam, ntRegexp was found #477

wants to merge 3 commits into from

Conversation

nu50218
Copy link

@nu50218 nu50218 commented Dec 22, 2019

maybe this will fix #426 .

Since the current (*node).findRoute does not check, If there is a route like r.Get('/url/{param:(\\w+)}/test', f) and get request /url//test (don't match), Router calls f and causes the bug.

Forked from #476 and fixed it, so if this PR will be merged, please also close #476 .

@pkieltyka
Copy link
Member

thanks for the report + suggestions -- fixed: 3658d98

@pkieltyka pkieltyka closed this Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URLParam need to check is nil or not
3 participants