Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use local kie client #99

Merged
merged 3 commits into from
Mar 9, 2020
Merged

use local kie client #99

merged 3 commits into from
Mar 9, 2020

Conversation

zhulijian1
Copy link
Contributor

@zhulijian1 zhulijian1 commented Mar 6, 2020

修改原因:
Fixes #100
修改内容:
kie client代码使用本项目内的,不再依赖github.com/apache/servicecomb-kie

@tianxiaoliang
Copy link
Member

tianxiaoliang commented Mar 6, 2020

kieclient.go文件名简化为client.go就可以,pkg名字已经表明了上下文,kie的仓库里的client删干净,UT要保留下来,我会把image推到 docker hub

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 56.16% when pulling a8dbf97 on zhulijian1:master into 4a50f1d on go-chassis:master.

@tianxiaoliang tianxiaoliang merged commit 9fc5b70 into go-chassis:master Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

与servicecomb-kie项目相互依赖
3 participants