Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support apollo source #90

Merged
merged 11 commits into from
Feb 10, 2020
Merged

support apollo source #90

merged 11 commits into from
Feb 10, 2020

Conversation

Shonminh
Copy link
Contributor

No description provided.

@Shonminh
Copy link
Contributor Author

Shonminh commented Jan 20, 2020 •
edited
Loading

  • 使用apollo client获取配置：https://github.com/Shonminh/apollo-client
    apollo client 维护了一块加锁的map，外部可以拿到一份map的拷贝，可以通过指定key获取map的value
  • 增加单元测试，增加apollo mock(目前在本地连接物理环境做的自测)
  • 注释完善
  • 增加example
  • 增加文档说明

tianxiaoliang
tianxiaoliang requested changes Jan 21, 2020
View reviewed changes
archaius.go Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jan 27, 2020 •
edited
Loading

Coverage Status

Coverage remained the same at 59.312% when pulling 864962e on Shonminh:develop into 32f6f1a on go-chassis:master.

tianxiaoliang
tianxiaoliang requested changes Feb 3, 2020
View reviewed changes
archaius.go Outdated Show resolved Hide resolved
@tianxiaoliang
Copy link
Member

门禁有没过的项目，请检查下

@Shonminh
Copy link
Contributor Author

Shonminh commented Feb 6, 2020

门禁有没过的项目，请检查下

已修正

@Shonminh Shonminh changed the title WIP: support apollo source support apollo source Feb 6, 2020
tianxiaoliang
tianxiaoliang requested changes Feb 7, 2020
View reviewed changes
options.go Outdated Show resolved Hide resolved
@tianxiaoliang tianxiaoliang merged commit d13df4a into go-chassis:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianxiaoliang tianxiaoliang tianxiaoliang requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Shonminh @coveralls @tianxiaoliang