fix panic when update with slice / map val #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
archaius_test.go
Outdated
| @@ -116,6 +114,20 @@ func TestConfig_RegisterListener(t *testing.T) { | |||
|
|
|||
| } | |||
|
|
|||
| func TestConfig_Update(t *testing.T) { | |||
| assert.NoError(t, archaius.Set("aNumber", 1)) | |||
There was a problem hiding this comment.
这个需要使用t.Run来给出一个case name。另外建议用表格驱动测试，来搞定这个简单的测试场景https://feixiao.github.io/testing/table_driven_test.html
否则长此以往，UT就不可维护了
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
修复一个 panic 错误，在 #151 中引入。
对应测试用例 TestConfig_Update，当配置值为 slice 或 map 时，发生 panic.